feat: add xUnit testing harness (#3044)

microsoft · Nov 21, 2024 · 8cd88de · 8cd88de
1 parent 876263f
commit 8cd88de
Show file tree

Hide file tree

Showing 15 changed files with 1,024 additions and 6 deletions.
diff --git a/src/Playwright.Examples/Program.cs b/src/Playwright.Examples/Program.cs
@@ -29,4 +29,3 @@
 var page = await browser.NewPageAsync();
 await page.GotoAsync("https://playwright.dev/dotnet");
 await page.ScreenshotAsync(new PageScreenshotOptions { Path = "screenshot.png" });
-
diff --git a/src/Playwright.TestingHarnessTest/Playwright.TestingHarnessTest.csproj b/src/Playwright.TestingHarnessTest/Playwright.TestingHarnessTest.csproj
@@ -13,11 +13,14 @@
     <PackageReference Include="MSTest.TestAdapter" Version="2.2.10" />
     <PackageReference Include="MSTest.TestFramework" Version="2.2.10" />
     <PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
+    <PackageReference Include="xunit" Version="2.9.2" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.8.2" />
   </ItemGroup>
 
   <ItemGroup>
     <ProjectReference Include="..\Playwright\Playwright.csproj" />
     <ProjectReference Include="..\Playwright.MSTest\Playwright.MSTest.csproj" />
     <ProjectReference Include="..\Playwright.NUnit\Playwright.NUnit.csproj" />
+    <ProjectReference Include="..\Playwright.Xunit\Playwright.Xunit.csproj" />
   </ItemGroup>
 </Project>
diff --git a/src/Playwright.TestingHarnessTest/tests/baseTest.ts b/src/Playwright.TestingHarnessTest/tests/baseTest.ts
@@ -24,7 +24,7 @@ export const test = base.extend<{
       const testDir = testInfo.outputPath();
       const testClassName = testInfo.titlePath.join(' ').replace(/[^\w]/g, '');
       for (const [fileName, fileContent] of Object.entries(files)) {
-        await fs.promises.writeFile(path.join(testDir, fileName), unintentFile(fileContent).replace('<class-name>', testClassName));
+        await fs.promises.writeFile(path.join(testDir, fileName), unintentFile(fileContent).replaceAll('<class-name>', testClassName));
       }
       const trxFile = path.join(testDir, 'result.trx');
       command += ` --logger "trx;logfilename=${trxFile}" --logger "console;verbosity=detailed" --filter "${testClassName}" ${path.join('..', '..')}`;

diff --git a/src/Playwright.TestingHarnessTest/tests/mstest/basic.spec.ts b/src/Playwright.TestingHarnessTest/tests/mstest/basic.spec.ts
@@ -182,7 +182,7 @@ test('should be able to make the browser headed via the env', async ({ runTest }
   expect(result.stdout).not.toContain("Headless")
 });
 
-test('should be able to to parse BrowserName and LaunchOptions.Headless from runsettings', async ({ runTest }) => {
+test('should be able to parse BrowserName and LaunchOptions.Headless from runsettings', async ({ runTest }) => {
   const result = await runTest({
     'ExampleTests.cs': `
       using System;
@@ -445,6 +445,7 @@ test.describe('Expect() timeout', () => {
     expect(result.total).toBe(1);
     expect(result.rawStdout).toContain("LocatorAssertions.ToHaveTextAsync with timeout 5000ms")
   });
+
   test('should be able to override it via each Expect() call', async ({ runTest }) => {
     const result = await runTest({
       'ExampleTests.cs': `

diff --git a/src/Playwright.TestingHarnessTest/tests/nunit/basic.spec.ts b/src/Playwright.TestingHarnessTest/tests/nunit/basic.spec.ts
@@ -181,7 +181,7 @@ test('should be able to make the browser headed via the env', async ({ runTest }
   expect(result.stdout).not.toContain("Headless")
 });
 
-test('should be able to to parse BrowserName and LaunchOptions.Headless from runsettings', async ({ runTest }) => {
+test('should be able to parse BrowserName and LaunchOptions.Headless from runsettings', async ({ runTest }) => {
   const result = await runTest({
     'ExampleTests.cs': `
       using System;
@@ -440,6 +440,7 @@ test.describe('Expect() timeout', () => {
     expect(result.total).toBe(1);
     expect(result.rawStdout).toContain("LocatorAssertions.ToHaveTextAsync with timeout 5000ms")
   });
+
   test('should be able to override it via each Expect() call', async ({ runTest }) => {
     const result = await runTest({
       'ExampleTests.cs': `
Original file line number	Diff line number	Diff line change
Expand Up		@@ -29,4 +29,3 @@
		var page = await browser.NewPageAsync();
		await page.GotoAsync("https://playwright.dev/dotnet");
		await page.ScreenshotAsync(new PageScreenshotOptions { Path = "screenshot.png" });