Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devops: delete .devcontainer/devcontainer.json #33709

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Nov 21, 2024

This file is outdated, we don't publish to this tag anymore since a while. It ends up in Ubuntu 20.04 image which is not supported anymore. I see two directions how to move forward:

a) stick with the default (removing - like this PR). Then we use the default GitHub Codespaces configuration
b) Maintain another set of Codespace configuration files - I don't see us doing this - since we do this in the playwright-browsers repository already.

@mxschmitt mxschmitt merged commit f43b86f into main Nov 21, 2024
28 of 29 checks passed
@mxschmitt mxschmitt deleted the mxschmitt-patch-1 branch November 21, 2024 11:22
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › playwright.ct-dev-server.spec.ts:21:5 › should run dev-server and use it for tests @macos-latest-node18-1

3 flaky ⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node18
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node22
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:23:5 › should print the correct imports and context options @ubuntu-20.04-chromium-tip-of-tree

37127 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants