-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update typescript code blocks in docs #35219
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. We intentionally use js
code blocks instead of ts
, because that produces better highlight on our documentation site.
Seems a bit weird to me that Example, |
I understand that, but the decision was made after looking quite a few snippets. I don't think we really want to change that for now. |
@dgozman Confusingly, there are already 36 code blocks with |
Yeah, that would be great. In fact, if you'd like to change those 36 |
- Some typescript codeblocks were defined asjs
instead ofts
Could not update API docs: 5ba5ac2Since only JS blocks are added to docs, not TS code blocks. Should probably be allowed?
--update-snapshots
string.substr