Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trace-viewer): add copy to clipboard button for traceviewer snapshot url on hover (#35213) #35255

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

alscotty
Copy link

Adds a new button on hover that copies snapshot url to clipboard, fixes [#35213]
(#35213)
And adds a test for the same
Screen Shot 2025-03-18 at 10 48 40 AM

@alscotty
Copy link
Author

@microsoft-github-policy-service agree

This comment has been minimized.

This comment has been minimized.

@alscotty
Copy link
Author

@dgozman could you review this one when possible? Thanks!

Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@alscotty
Copy link
Author

Thanks for reviewing @dgozman ! Made those suggested changes and retested

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › tests/runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1

4 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-device.spec.ts:45:5 › device › should scroll to click @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @webkit-ubuntu-22.04-node18

38812 passed, 809 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants