Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prompt button should not be hidden by error #35268

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Mar 19, 2025

Closes #35251

Old:
Screenshot 2025-03-19 at 11 36 31

New:

Screen.Recording.2025-03-19.at.11.52.34.mov

@Skn0tt Skn0tt requested a review from pavelfeldman March 19, 2025 10:54
@Skn0tt Skn0tt self-assigned this Mar 19, 2025
Copy link
Contributor

Test results for "tests 1"

2 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18

38786 passed, 808 skipped
✔️✔️✔️

Merge workflow run.

@Skn0tt Skn0tt requested a review from agg23 March 21, 2025 11:37
@agg23
Copy link
Contributor

agg23 commented Mar 21, 2025

Looks correct.

@Skn0tt Skn0tt merged commit 6f1ec11 into microsoft:main Mar 25, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants