Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special handling for getSelection() with Firefox from tests #35271

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove special handling for getSelection() with Firefox from tests #35271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/page/elementhandle-select-text.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ it('should select textarea', async ({ page, server, browserName }) => {
const textarea = await page.$('textarea');
await textarea.evaluate(textarea => textarea.value = 'some value');
await textarea.selectText();
if (browserName === 'firefox' || browserName === 'webkit') {
if (browserName === 'webkit') {
expect(await textarea.evaluate(el => el.selectionStart)).toBe(0);
expect(await textarea.evaluate(el => el.selectionEnd)).toBe(10);
} else {
Expand All @@ -35,7 +35,7 @@ it('should select input', async ({ page, server, browserName }) => {
const input = await page.$('input');
await input.evaluate(input => input.value = 'some value');
await input.selectText();
if (browserName === 'firefox' || browserName === 'webkit') {
if (browserName === 'webkit') {
expect(await input.evaluate(el => el.selectionStart)).toBe(0);
expect(await input.evaluate(el => el.selectionEnd)).toBe(10);
} else {
Expand Down
2 changes: 1 addition & 1 deletion tests/page/locator-misc-2.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ it('should select textarea', async ({ page, server, browserName }) => {
const textarea = page.locator('textarea');
await textarea.evaluate(textarea => (textarea as HTMLTextAreaElement).value = 'some value');
await textarea.selectText();
if (browserName === 'firefox' || browserName === 'webkit') {
if (browserName === 'webkit') {
expect(await textarea.evaluate(el => (el as HTMLTextAreaElement).selectionStart)).toBe(0);
expect(await textarea.evaluate(el => (el as HTMLTextAreaElement).selectionEnd)).toBe(10);
} else {
Expand Down
11 changes: 2 additions & 9 deletions tests/page/retarget.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ it('input value retargeting', async ({ page, browserName }) => {
await expect(target).toHaveValue('bar');

await target.selectText();
if (browserName === 'firefox' || browserName === 'webkit') {
if (browserName === 'webkit') {
expect(await page.locator('#target').evaluate((el: HTMLInputElement) => el.selectionStart)).toBe(0);
expect(await page.locator('#target').evaluate((el: HTMLInputElement) => el.selectionEnd)).toBe(3);
} else {
Expand Down Expand Up @@ -270,14 +270,7 @@ it('selection retargeting', async ({ page, browserName }) => {
await expect(page.locator('#target')).toHaveText('foo');

await target.selectText();
if (browserName === 'firefox') {
expect(await page.$eval('#target', target => {
const selection = window.getSelection()!;
return selection.anchorNode === target && selection.focusNode === target;
})).toBe(true);
} else {
expect(await page.evaluate(() => window.getSelection()!.toString())).toBe('foo');
}
expect(await page.evaluate(() => window.getSelection()!.toString())).toBe('foo');
});
}
});
Expand Down
Loading