chore: provide more actionable error messages when serializing values #35297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agg23
force-pushed
the
function-serialize-error-message
branch
from
92307f0 to
8be57a2
Compare
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"5 flaky38807 passed, 808 skipped Merge workflow run. |
pavelfeldman
approved these changes
Mar 25, 2025
| function accessChainToDisplayString(accessChain: Array<string | number>): string { | ||
| const chainString = accessChain.map((accessor, i) => { | ||
| if (typeof accessor === 'string') | ||
| return i ? `.${accessor}` : accessor; |
There was a problem hiding this comment.
This will have spaces (fyi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialization failures (primarily when attempting to serialize functions) provide a vague error message that is not helpful. Provide a more actionable message.