Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use path as key in div #35317

Merged
merged 1 commit into from
Mar 24, 2025
Merged

chore: use path as key in div #35317

merged 1 commit into from
Mar 24, 2025

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Mar 21, 2025

follow-up to #35309 - there already was a key prop that I didn't see 🤦

@Skn0tt Skn0tt requested a review from mxschmitt March 21, 2025 14:56
@Skn0tt Skn0tt self-assigned this Mar 21, 2025
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [webkit-library] › tests/library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @webkit-ubuntu-22.04-node18

5 flaky ⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-ubuntu-22.04-node20
⚠️ [chromium-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-ubuntu-22.04-node22
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18

38809 passed, 811 skipped
✔️✔️✔️

Merge workflow run.

@Skn0tt Skn0tt merged commit 6282151 into microsoft:main Mar 24, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants