feat(j unit reporter): adds reporting on retries to JUnit reporter #35323
+111
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Shopify" |
carolopolo
commented
Mar 21, 2025
| @@ -102,6 +102,17 @@ class JUnitReporter implements ReporterV2 { | |||
| } | |||
| } | |||
|
|
|||
| private _extractErrorAttributes(error: TestError) { | |||
| let message = ''; | |||
There was a problem hiding this comment.
we could provide a default error message
carolopolo
changed the title
Test results for "tests 1"5 flaky38812 passed, 809 skipped Merge workflow run. |
carolopolo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29446
Currently, test retries aren't captured in Playwright's JUnit reporter output, and consumers don't have the ability to easily perform flaky test analysis. Also, test case records currently don't have a
pathattribute, which is important for some tools parsing failure outputs for analytics.This PR adds reporting on every retry and outputs a
<failure>per attempt, and modifies themessageandtypeattributes. Since we're now iterating through thetest.results, this PR attachestest.annotationsto the last test run. Since "it is important to only produce a single system-out entry", that is now attached to the last test run.This is just a starting point of what this feature could look like, and I'd love to your feedback!