Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devops: drop environment: allow-uploading-flakiness-results #35324

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Mar 21, 2025

The only mention of the 'environment' is https://github.com/marketplace/actions/azure-login#environment, which is different than job environment.

@yury-s yury-s requested a review from mxschmitt March 21, 2025 23:45
Copy link
Contributor

Test results for "tests 1"

5 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:205:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18

38812 passed, 809 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this in order to allow the OIDC login via uses: azure/login@v2. This value is reflected on the Azure Portal side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants