Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce compile-time complexity of combined_dispatch_prototype::overload_types #60

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

mingxwa
Copy link
Collaborator

@mingxwa mingxwa commented Jan 18, 2024

Due to the design of overloads_combination_traits, the compile-time complexity to deduce combined_dispatch_prototype::overload_types is about O(n^3), which can theoretically be reduced to O(n^2) before std::meta (hopefully) in C++26. In this change, flattening_traits was split into two, recursive_reduction and flat_reduction. recursive_reduction is subsequently used in the definition of combined_dispatch_prototype::overload_types.

No functional changes.

@mingxwa mingxwa requested review from tian-lt, guominrui and a team January 18, 2024 14:35
@mingxwa mingxwa merged commit baa0f87 into microsoft:main Jan 18, 2024
4 checks passed
@mingxwa mingxwa deleted the user/mingxwa/refactoring branch January 18, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants