Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grayscale filter for block #294

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Add grayscale filter for block #294

wants to merge 2 commits into from

Conversation

shakao
Copy link
Contributor

@shakao shakao commented May 1, 2020

put this together really quick--right now it just applies it to the individual block, i'm not sure how the blocks diff works but you probably traverse the children yourself?

if you do 'gulp publish --closure-library' you should be able to build this branch locally for pxt and test it out

@shakao shakao requested a review from pelikhan May 1, 2020 15:00
Copy link
Member

@pelikhan pelikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I can recourse the tree

@pelikhan
Copy link
Member

It does not seem to apply to dropdowns properly. The setColour works. Can we make a bit lighter?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants