Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target docs and images for 'identity' and 'share' pages #5369

Merged
merged 6 commits into from
Oct 13, 2023
Merged

Target docs and images for 'identity' and 'share' pages #5369

merged 6 commits into from
Oct 13, 2023

Conversation

ganicke
Copy link
Collaborator

@ganicke ganicke commented Oct 10, 2023

Target specific images for the 'Identity' and 'Share' pages update.

Depends on microsoft/pxt#9713

Closes #5366

@ganicke ganicke changed the title Target images for 'identity' and 'share' pages Target docs and images for 'identity' and 'share' pages Oct 10, 2023
@ganicke ganicke requested a review from Jaqster October 11, 2023 01:01
Jaqster
Jaqster approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@Jaqster Jaqster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Galen!

@ganicke
Copy link
Collaborator Author

ganicke commented Oct 11, 2023 •
edited
Loading

Seems that pxt checkdocs is missing something. The /homepage-content link should be valid. The extended SUMMARY.md is trying to include it.

image

image

@Jaqster
Copy link
Member

Jaqster commented Oct 11, 2023

@abchatra - do you know why this is failing?

@abchatra
Copy link
Collaborator

Seems like passed now?

@ganicke
Copy link
Collaborator Author

ganicke commented Oct 11, 2023 •
edited
Loading

No, I took it out of the extended SUMMARY for now. Isn't the build pulling HEAD? My local pxt checkdocs passes this check with the updated SUMMARY. It worked previously when the miscellaneous section was only int the pxt-core base SUMMARY. Now that it's overridden in the target SUMMARY, the broken link occurs.

@abchatra
Copy link
Collaborator

@riknoll ?

@ganicke ganicke merged commit 975c890 into master Oct 13, 2023
6 checks passed
@ganicke ganicke deleted the update-identity-share-docs branch October 13, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaqster Jaqster Jaqster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the 'identity' and 'share' docs
3 participants
@ganicke @Jaqster @abchatra