add new pin shadow blocks and field editor #5863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh also, this PR relies on microsoft/pxt#10118 but is safe to merge without it! |
srietkerk
approved these changes
Aug 26, 2024
| //% shim=TD_ID | ||
| //% blockId=digital_pin | ||
| //% block="digital pin $pin" | ||
| //% pin.fieldEditor=pinpicker |
There was a problem hiding this comment.
I see that the field editor for the gridpicker had quotes around it, are the quotes not needed?
There was a problem hiding this comment.
nope! they don't hurt anything, i just like no quotes better
kimprice
approved these changes
Aug 27, 2024
|
@carlosperate @jaustin please take a look at /beta and ensure all issues of pins are addressed as expected. |
|
@abchatra @carlosperate @jaustin Please see new comments added to #5834 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5733
This PR does a few things:
P0instead ofanalog pin P0analog readblock so that it only lists the analog-readable pinsanalog readblock (see GIF below). This field editor is otherwise identical to the gridpickerpins.analogPinandpins.digitalPinfunctions so that they start with an underscore, which means they get filtered out of the TS intellisense(write only)text from the analog pin selector since the new field editor gives warnings insteadHere's what the warning looks like:
@sae220 FYI