Disable "Reload on Update" for teacher tool iframes #5875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wn in communication between the teacher tool and the webapp in the iframe. We can handle this ourselves instead.
jwunderl
approved these changes
Aug 28, 2024
eanders-ms
approved these changes
Aug 28, 2024
thsparks
added a commit
to microsoft/pxt
that referenced
this pull request
Aug 29, 2024
With microsoft/pxt-microbit#5875, we disabled the automatic webapp reload that occurs when a new service worker is registered. We did that because the unexpected reload was causing microsoft/pxt-microbit#5824 and microsoft/pxt-microbit#5822. Now, however, we have to handle that refresh ourselves. In this change, we listen for the event added in #10120 and refresh the iframe (via changing the src) when we get it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per microsoft/pxt#10120, this adds the noReloadOnUpdate flag to our teachertool query variant, which gets added to the url passed into the iframe on the teacher tool.
When this is set, the webapp won't automatically reload when the service worker updates, which was causing unloaded projects (#5824) and a breakdown in communication between the teacher tool and the webapp (#5822).
We'll have to manually handle the reload in the teacher tool, but that will be a separate change in pxt.