Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the 'windows app' page into target doc space #8434

Merged
merged 3 commits into from
Aug 25, 2021

Conversation

ganicke
Copy link
Collaborator

@ganicke ganicke commented Aug 25, 2021

The page is moved into ./common-docs from docs in order for it to be extensible to the target windows-app.md pages. The page is updated with extend sections and a bit more text.

RE: microsoft/pxt-microbit#4159, microsoft/pxt-microbit#4184

@@ -0,0 +1,29 @@
# MakeCode Windows app

Some MakeCode editors also have an associated Windows app which contains
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this referring to the Electron app? I think electron isn't just Windows (but this IS for the windows app page....so feel free to ignore 😅) And I'm not sure how we refer to the Electron app externally -- offline app?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH This is about the windows app! Sorry ignore me

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's publish method for the Electron app vs. the Windows app? Windows app store?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

electron app I think we just have a link to on our site. lemme grab a link...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://makecode.microbit.org/offline-app yeah it's linked to in the offline page

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this app alternative info will go in a pxt-microbit/windows-app.md extended page after this is merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo gotcha

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm late in doing this. Should've coordinated before microsoft/pxt-microbit#4184 went in. Better nate than lever.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry D:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, really. We are Flexy Bull.

image

@ganicke ganicke changed the title Move the 'web app' page into target doc space Move the 'windows app' page into target doc space Aug 25, 2021
@ganicke ganicke merged commit c32d569 into master Aug 25, 2021
@ganicke ganicke deleted the move-winapp-deprecate-page branch August 25, 2021 23:20
eanders-ms pushed a commit that referenced this pull request Sep 7, 2021
* move page to common-docs

* update the page info a bit

* the 'the'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants