Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yotta config section to pxt.json doc page #9637

Merged
merged 5 commits into from
Aug 11, 2023
Merged

Conversation

ganicke
Copy link
Collaborator

@ganicke ganicke commented Aug 11, 2023

Some DAL config examples/description added to the pxt.json page.

Not sure if this is correct, but I 'yotta' know by now.

Closes microsoft/pxt-microbit#5329

@ganicke ganicke requested a review from jwunderl August 11, 2023 22:02
Copy link
Member

@jwunderl jwunderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganicke ganicke merged commit 20e0eaa into master Aug 11, 2023
6 checks passed
@ganicke ganicke deleted the add-yotta-note-pxtjson branch August 11, 2023 22:42
@bsiever
Copy link

bsiever commented Aug 11, 2023

👍 for the"'yotta' know"

@bsiever
Copy link

bsiever commented Aug 11, 2023

One issue that triggered this was about the interplay between bluetooth security settings, the values inherited by extensions, and the UI behavior in MakeCode. Specifically, I have an extension that's doing:

  "yotta": {
        "config": {
            "microbit-dal": {
                "bluetooth": {
                    "open": 1
                }
            }
        }
    }

I think there's a compelling reason for open security for my extension, as described here: microsoft/pxt-microbit#5202 (comment) , but Martin (@martinwork) discovered some unusual behavior in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Information about setting build config macros in extensions and user settings
3 participants