Replace isort with Ruff #325
Conversation
| combine_as_imports = true | ||
| line_length = 130 | ||
| extra_standard_library = [ | ||
| [tool.ruff] |
There was a problem hiding this comment.
If we're going to use ruff for linting, why not replace black and use ruff for formatting also?
There was a problem hiding this comment.
Let's do that in a separate PR I guess, since it may cause a lot of noise.
There was a problem hiding this comment.
My reasoning was that typeshed (which is the endgoal for these stubs if not upstreamed to first-party) still uses black (for historical collaboration reasons, see python/typeshed#11734).
That being said, a formatter run is really easy and any difference would quickly be resolved when upstreaming, so if you wanna go Ruff for formatting, I'm happy to open a PR for it as well.
There was a problem hiding this comment.
I don't feel strongly about switching to ruff for formatting. We can do it later if someone is inspired.
FWIW, I don't think "typeshed uses it" is a reason to stick with black since if we push something to typeshed it's trivial to run black on it at that time.
Much faster and brings the configs closer to typeshed's