Skip to content

Commit

Permalink
fix_ci_error
Browse files Browse the repository at this point in the history
  • Loading branch information
SunsetWolf committed Dec 26, 2024
1 parent 405f94a commit 6b91dea
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 6 deletions.
1 change: 1 addition & 0 deletions .github/workflows/test_qlib_from_pip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
run: |
python -m pip install --upgrade pip
# Will cancel this step when the next qlib version is released. The current qlib version is: 0.9.6
- name: Installing pywinpt for windows
if: ${{ matrix.os == 'windows-latest' }}
run: |
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/test_qlib_from_source.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ jobs:
if: ${{ matrix.os == 'windows-latest' }}
run: |
python -m pip install torch torchvision torchaudio
python -m pip install pywinpty --only-binary=:all:
- name: Set up Python tools
run: |
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/test_qlib_from_source_slow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@ jobs:
with:
python-version: ${{ matrix.python-version }}

- name: Installing pywinpt for windows
if: ${{ matrix.os == 'windows-latest' }}
run: |
python -m pip install pywinpty --only-binary=:all:
- name: Set up Python tools
run: |
make dev
Expand Down
14 changes: 14 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ PUBLIC_DIR := $(shell [ "$$READTHEDOCS" = "True" ] && echo "$$READTHEDOCS_OUTPUT
SO_DIR := qlib/data/_libs
SO_FILES := $(wildcard $(SO_DIR)/*.so)

ifeq ($(OS),Windows_NT)
IS_WINDOWS = true
else
IS_WINDOWS = false
endif

########################################################################################
# Development Environment Management
########################################################################################
Expand Down Expand Up @@ -62,6 +68,14 @@ prerequisite:
dependencies:
python -m pip install -e .

# pywinpty as a dependency of jupyter on windows, if you use pip install pywinpty installation,
# will first download the tar.gz file, and then locally compiled and installed,
# this will lead to some unnecessary trouble, so we choose to install the compiled whl file, to avoid trouble.
pywinpt:
ifeq ($(IS_WINDOWS),true)
python -m pip install pywinpty --only-binary=:all:
endif

lightgbm:
python -m pip install lightgbm --prefer-binary

Expand Down

0 comments on commit 6b91dea

Please sign in to comment.