Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the empty price_s case and self.instruments in SBBStrategyEMA. #1677

Merged
merged 4 commits into from
Dec 26, 2024
Merged

Fix the empty price_s case and self.instruments in SBBStrategyEMA. #1677

merged 4 commits into from
Dec 26, 2024

Conversation

ChiahungTai
Copy link
Collaborator

Description

  1. Deal with price_s.empty:
  2. Deal with instruments is List

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@github-actions github-actions bot added the waiting for triage Cannot auto-triage, wait for triage. label Oct 21, 2023
@ChiahungTai
Copy link
Collaborator Author

@Fivele-Li @you-n-g,
Looks like the pylint has some problems, I think that is not my code's problem. Can you guys give me some suggestions to fix it?

@ChiahungTai ChiahungTai requested a review from you-n-g October 22, 2023 01:27
@SunsetWolf SunsetWolf merged commit 23d9d5a into microsoft:main Dec 26, 2024
183 checks passed
@SunsetWolf
Copy link
Collaborator

Thank you for your contribution. Now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@you-n-g you-n-g you-n-g left review comments

Assignees
No one assigned
Labels
waiting for triage Cannot auto-triage, wait for triage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChiahungTai @SunsetWolf @you-n-g