-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More dataloader example #1823
Merged
Merged
More dataloader example #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting for triage
Cannot auto-triage, wait for triage.
label
Jul 5, 2024
you-n-g
reviewed
Jul 9, 2024
qlib/data/dataset/loader.py
Outdated
except: | ||
instruments = None | ||
df_current = dl.load(instruments, start_time, end_time) | ||
warnings.warn("If the value of `instruments` is csi300, it will set instruments to None to get all the data.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
csi300 hard coded !
qlib/data/dataset/loader.py
Outdated
try: | ||
df_current = dl.load(instruments, start_time, end_time) | ||
except: | ||
instruments = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whguWe can use instruments=None
intead of changing the variable (which may cause later errors.)
you-n-g
force-pushed
the
more_data_loader_example
branch
from
July 10, 2024 05:10
aa903c2
to
ebdfdc7
Compare
SunsetWolf
added
enhancement
New feature or request
and removed
waiting for triage
Cannot auto-triage, wait for triage.
labels
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.py
under upper directory ofqlib
.Screenshots of Test Results (if appropriate):
Types of changes