Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More dataloader example #1823

Merged
merged 12 commits into from
Jul 10, 2024
Merged

More dataloader example #1823

merged 12 commits into from
Jul 10, 2024

Conversation

SunsetWolf
Copy link
Collaborator

Description

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@github-actions github-actions bot added the waiting for triage Cannot auto-triage, wait for triage. label Jul 5, 2024
except:
instruments = None
df_current = dl.load(instruments, start_time, end_time)
warnings.warn("If the value of `instruments` is csi300, it will set instruments to None to get all the data.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

csi300 hard coded !

try:
df_current = dl.load(instruments, start_time, end_time)
except:
instruments = None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whguWe can use instruments=None intead of changing the variable (which may cause later errors.)

@you-n-g you-n-g force-pushed the more_data_loader_example branch from aa903c2 to ebdfdc7 Compare July 10, 2024 05:10
@you-n-g you-n-g merged commit 2c33332 into main Jul 10, 2024
26 checks passed
@you-n-g you-n-g deleted the more_data_loader_example branch July 10, 2024 08:01
@SunsetWolf SunsetWolf added enhancement New feature or request and removed waiting for triage Cannot auto-triage, wait for triage. labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants