Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codepush HOC should unmount app before restart #2621

Closed
wants to merge 3 commits into from

Conversation

savv
Copy link

@savv savv commented Nov 21, 2023

RN Apps currently don't get the opportunity to destruct themselves prior to a restart, leading to crashes and bugs:

#2567 (comment)

This is an attempt to mitigate these crashes, by properly unmounting <App />.

I'm looking forward to your feedback

@savv savv requested a review from a team as a code owner November 21, 2023 12:47
@savv
Copy link
Author

savv commented Nov 21, 2023

@microsoft-github-policy-service agree

@savv
Copy link
Author

savv commented Nov 30, 2023

ping?

@viniciusmoreria
Copy link

this is not missing the state in the class construtor?

      constructor() {
        super();
        this.state = { inactive: false };
      }

@velimir-jankovic
Copy link
Contributor

@savv Thank you for this contribution! I'm a bit concerned that we may affect existing apps with this change.
I think it would be a good idea to put this change behind an option (for now), what do you think?

@DmitriyKirakosyan
Copy link
Contributor

Closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants