Return and Space keys do not trigger onPress events

[tom-un]

Please select one of the following

• I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
• I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
• I am making a fix / change for the macOS implementation of react-native
• I am making a change required for Microsoft usage of react-native

Summary

This is a fix for Issue 1622 . This fixes a regression that was introduced in .68 when the validKeysDown/validKeysUp View props were introduced. Since then various Pressability components (Pressable, and Touchable*) do not trigger onPress events when the Return or Spacebar key is pressed.

The fix involves triggering the onPressIn and onPressOut events in Pressibility's onKeyDown/onKeyUp handlers similar to how react-native-windows also does this: https://github.com/microsoft/react-native-windows/blob/main/vnext/src/Libraries/Pressability/Pressability.windows.js. It also triggers the onPress on key down which mimics how most macOS controls respond to key down as a click in contrast to Windows which triggers onPress on key up.

Logic was also added to RCTView's keyboardEvent: filtering logic: if the view is focusable and it does not have validKeyDown/Up props, it implicitly allows the Return and Spacebar keys.

Changelog

[macOS] [Fix] - Return and Space keys do not trigger onPress events

Test Plan

All the Pressable and Touchable pages in RNTester were tested:

Note that this change is very similar to Saad's PR here: #1614. The changes to Pressability event handlers are identical in both PRs. But in Saad's the validKeysDown prop is giving a default value of Enter and Space in the Pressability.js while this PR makes the default values of the validKeysDown/Up in the native RCTView. The advantage of doing it in the native side means that the Touchable* components also get the correct behavior without making very large scale changes to the various Touchable* files -- Saad's change only fixes Pressable. Also the other PR only makes default values for validKeysDown and not also validKeysUp, so the Press Out effects never trigger leaving the component in a "stuck" state. Here is a sample of the Pressable test in the other branch:

[Saadnajmi]

Long term I'd still rather the logic live in JS like in #1614 . However, given that change needs more work and this affects people now, I say we merge/backport this version. If/when #1615 lands, this logic would change anyway.