-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.75] Cherry-pick fixes #14106
[0.75] Cherry-pick fixes #14106
Commits on Nov 12, 2024
-
[Fabric] Introducing autocapitalize prop in TextInput - Take 2 (micro…
…soft#13343) * New implementation of autocapitalize! * Change files * Fixed bug for sentences scenario * Just keep characters mode for now * Revert "Just keep characters mode for now" This reverts commit 60ca1ce. * Re-apply changes minus packages.json.lock * The original js file was deleted, re-applying changes * Fixed snapshot and lint errors * Fix override mismatch, added comments * Remove stale test check * Minor changes * Update obsolete snapshot
Configuration menu - View commit details
-
Copy full SHA for a957e8c - Browse repository at this point
Copy the full SHA a957e8cView commit details -
Cleanup ReactNativeAppBuilder and ReactNativeWin32App (microsoft#13983)
This PR simplifies and scopes down the API for `ReactNativeAppBuilder` and `ReactNativeWin32App`. - Bug fix (non-breaking change which fixes an issue) `ReactNativeAppBuilder`'s API surface made it too easy to call incorrectly and not realize it. Resolves microsoft#13946 There are a variety of changes to the API surface: * `ReactInstanceSettingsBuilder` deleted: not only are there are simply too many APIs that would need to be exposed to be useful, the very act of creating and replacing the app's `ReactNativeHost`'s `ReactInstanceSettings` with a new one is what caused the bug in microsoft#13946 in the first place * `ReactNativeAppBuilder` now only exposes APIs to specify the intial, non-ReactNative, WinAppSDK types, (i.e. `DispatcherQueueController`, `Compositor`, and `AppWindow`), objects the app developer may already have created for their existing app, and otherwise is only responsible for building a `ReactNativeWin32App` with those types properly pre-made * `ReactNativeWin32App::Start()` is now more responsible for the stitching together all of the relevant types to make a working Win32 fabric app * All WinRT APIs without an immediate use-case have been commented out until we are sure they are necessary and that it is safe to expose them * The template has been updated to follow the pattern of: * Use `ReactNativeAppBuilder` to get a `ReactNativeWin32` app with the base WinAppSDK types ready * Get and modify the types as necessary from the created app object (like the `ReactInstanceSettings` and the `AppWindow`) * Call `app.Start()` N/A Verified new apps and example apps in libraryes build and run properly. Should this change be included in the release notes: _yes_ Cleanup ReactNativeAppBuilder and ReactNativeWin32App
Configuration menu - View commit details
-
Copy full SHA for 461c16c - Browse repository at this point
Copy the full SHA 461c16cView commit details -
Update Guardrails on Provider Instantiation (microsoft#13961)
* Update Provider Guardrails * Change files * Format * Update Snapshots
Configuration menu - View commit details
-
Copy full SHA for f8a5747 - Browse repository at this point
Copy the full SHA f8a5747View commit details -
Add very basic box-shadow support (microsoft#14028)
* Add very basic box-shadow support * Change files
Configuration menu - View commit details
-
Copy full SHA for 4370c5c - Browse repository at this point
Copy the full SHA 4370c5cView commit details -
Focus should notify island host when tab loop wraps to give host opor…
…tunity to take focus (microsoft#14026) * Focus should notify island host when tab loop wraps to give host oportunity to take focus * Change files
Configuration menu - View commit details
-
Copy full SHA for cee6b12 - Browse repository at this point
Copy the full SHA cee6b12View commit details -
Default scroll to bring a component into view should have padding aro…
…und the viewport (microsoft#14018) * Default scroll to bring a component into view should have padding around the viewport * Change files
Configuration menu - View commit details
-
Copy full SHA for 27a4b42 - Browse repository at this point
Copy the full SHA 27a4b42View commit details -
Update focus visuals to use cornerRadius and inner/outer strokes (mic…
…rosoft#14008) * Update focus visuals to use cornerRadius and inner/outer strokes. * Change files * Format * lint fix * Scale focus border for scaleFactor
Configuration menu - View commit details
-
Copy full SHA for b40dee5 - Browse repository at this point
Copy the full SHA b40dee5View commit details -
[Fabric] Get Modal to host RN components in new hwnd (microsoft#13500)
* save state * add example * build but blank page still :( * clean up comments * visuals show up in new hwnd! * clean up code * better naming and unfork Modal examples * testing save state * Make the RN island a Modal member var * Failed attempt at skipping root view in CEH, leaving it for learning purposes * you can click on UI! * clean up code * Change files * save state * remove hardcoded rootTag * add width/height to example * add test * revert simple.tsx * remove test * update snapshot * feedback part 1: make Modal a RootComponentView * feedback part2: simplify MountChildren * fix deleting modal * feedback round2 * remove comment * remove imports * feedback part 3 * fix overrides * add simple layout - still has issues with padding/flex * feedback part4 * lint * update overrides * Change files * feedback --------- Co-authored-by: Daniel Ayala <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a52da19 - Browse repository at this point
Copy the full SHA a52da19View commit details -
Support accessibilityState 'checked' (microsoft#13962)
* Implement accessibilityState checked * Change files * Add Testing * Format and Update Snapshots * Adjust Guardrails * Merge * Format * Format * Lint * Change files * Fix Merge Error
Configuration menu - View commit details
-
Copy full SHA for e103261 - Browse repository at this point
Copy the full SHA e103261View commit details -
Fix issue with prop cloning with custom native props (microsoft#14061)
* Fix issue with prop cloning with custom native props * format * prettier * Change files --------- Co-authored-by: React-Native-Windows Bot <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bce3833 - Browse repository at this point
Copy the full SHA bce3833View commit details -
Export MS.RN.Color ctor in Office dll (microsoft#14082)
* Export MS.RN.Color ctor in Office dll * Change files * Implement TxScreenToClient and TxClientToScreen * format --------- Co-authored-by: React-Native-Windows Bot <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4a4b747 - Browse repository at this point
Copy the full SHA 4a4b747View commit details -
TextInput caret becomes visible on non-focused TextInputs on resize (m…
…icrosoft#14091) * TextInput caret becomes visible on non-focused TextInputs on resize * Change files --------- Co-authored-by: React-Native-Windows Bot <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f3f0db4 - Browse repository at this point
Copy the full SHA f3f0db4View commit details -
Fix focus visuals being obscured by adjacent views (microsoft#14093)
* Fix focus visuals being obscured by adjacent views * Change files * update snapshots * Fix uimplemented view * review feedback --------- Co-authored-by: React-Native-Windows Bot <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9e1665f - Browse repository at this point
Copy the full SHA 9e1665fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ebdf52 - Browse repository at this point
Copy the full SHA 6ebdf52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f6cf9b - Browse repository at this point
Copy the full SHA 6f6cf9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 51f9c81 - Browse repository at this point
Copy the full SHA 51f9c81View commit details
Commits on Nov 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 183a3dc - Browse repository at this point
Copy the full SHA 183a3dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9ea1c4 - Browse repository at this point
Copy the full SHA b9ea1c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0734dbc - Browse repository at this point
Copy the full SHA 0734dbcView commit details