Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing references to OpenAPI #355

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

earth2marsh
Copy link

Now should align with the guidelines in the OpenAPI style guide reference here: https://github.com/OAI/OpenAPI-Style-Guide

Now should align with the guidelines in the OpenAPI style guide reference here: https://github.com/OAI/OpenAPI-Style-Guide
Copy link
Contributor

@marina-p marina-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@marina-p
Copy link
Contributor

Thanks for the updates!

@PatGod
Copy link
Contributor

PatGod commented Sep 28, 2021

Yes, but these 'fixes' are only for the first main page - what about all the .md files? If you feel passionate about this, could please fix these as well? Thanks!

1. **Compile:** from a Swagger JSON or YAML specification (and optionally examples), generate a RESTler grammar. See [Compiling](./docs/user-guide/Compiling.md).
2. **Test:** execute quickly all of the endpoints+methods in a compiled RESTler grammar for debugging the test setup and compute what parts of the Swagger spec are covered. This mode is also called a *smoketest*.
1. **Compile:** from an OpenAPI document in either JSON or YAML format (and optionally examples), generate a RESTler grammar. See [Compiling](./docs/user-guide/Compiling.md).
2. **Test:** execute quickly all of the endpoints+methods in a compiled RESTler grammar for debugging the test setup and compute what parts of the OpenAPI Specification are covered. This mode is also called a *smoketest*.
See [Testing](./docs/user-guide/Testing.md). To use custom test engine settings, see [Test Engine Settings](./docs/user-guide/SettingsFile.md).
Copy link
Contributor

@PatGod PatGod Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should not be an upper case to 'Specification' here.

@@ -66,8 +66,8 @@ Prerequisites: Install [Python 3.8.2](https://www.python.org/downloads/) and

RESTler runs in 4 main modes (in order):

1. **Compile:** from a Swagger JSON or YAML specification (and optionally examples), generate a RESTler grammar. See [Compiling](./docs/user-guide/Compiling.md).
2. **Test:** execute quickly all of the endpoints+methods in a compiled RESTler grammar for debugging the test setup and compute what parts of the Swagger spec are covered. This mode is also called a *smoketest*.
1. **Compile:** from an OpenAPI document in either JSON or YAML format (and optionally examples), generate a RESTler grammar. See [Compiling](./docs/user-guide/Compiling.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace 'document' by 'specification' for consistency

RESTler intelligently infers producer-consumer dependencies among request types from the Swagger
specification. During testing, it checks for specific classes of bugs
RESTler intelligently infers producer-consumer dependencies among request types from the OpenAPI
document. During testing, it checks for specific classes of bugs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace 'document' by 'specification' for consistency

@@ -91,7 +91,7 @@ When a bug is found, RESTler reports bugs triaged in bug buckets, and provides a

## Advanced Topics

For tips on using RESTler effectively, please see [Best Practices](./docs/user-guide/BestPractices.md) and [Improving Swagger Coverage](./docs/user-guide/ImprovingCoverage.md).
For tips on using RESTler effectively, please see [Best Practices](./docs/user-guide/BestPractices.md) and [Improving OpenAPI Coverage](./docs/user-guide/ImprovingCoverage.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'OpenAPI' should really be 'API' here.

@PatGod
Copy link
Contributor

PatGod commented Sep 28, 2021

PS: feel free to merge and I can clean this up later. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants