feat: add extra context to errors (#959)

Enhance error handling by wrapping errors with additional context during
plugin operations and eBPF compilation.

pkg/managers/pluginmanager/pluginmanager.go

@@ -102,18 +102,18 @@ func (p *PluginManager) Reconcile(ctx context.Context, plugin api.Plugin) error
 	// Regenerate eBPF code and bpf object.
 	// This maybe no-op for plugins that don't use eBPF.
 	if err := plugin.Generate(ctx); err != nil {
-		return err
+		return errors.Wrap(err, "failed to generate plugin")
 	}
 	if err := plugin.Compile(ctx); err != nil {
-		return err
+		return errors.Wrap(err, "failed to compile plugin")
 	}
 
 	// Re-start plugin.
 	if err := plugin.Stop(); err != nil {
-		return err
+		return errors.Wrap(err, "failed to stop plugin")
 	}
 	if err := plugin.Init(); err != nil {
-		return err
+		return errors.Wrap(err, "failed to init plugin")
 	}
 
 	p.l.Info("Reconciled plugin", zap.String("name", plugin.Name()))

pkg/plugin/dropreason/dropreason_linux.go

@@ -8,7 +8,6 @@ import (
 	"bytes"
 	"context"
 	"encoding/binary"
-	"errors"
 	"fmt"
 	"os"
 	"path"
@@ -30,6 +29,7 @@ import (
 	plugincommon "github.com/microsoft/retina/pkg/plugin/common"
 	_ "github.com/microsoft/retina/pkg/plugin/dropreason/_cprog" // nolint
 	"github.com/microsoft/retina/pkg/utils"
+	"github.com/pkg/errors"
 	"go.uber.org/zap"
 )
 
@@ -109,7 +109,7 @@ func (dr *dropReason) Compile(ctx context.Context) error {
 	// Keep target as bpf, otherwise clang compilation yields bpf object that elf reader cannot load.
 	err = loader.CompileEbpf(ctx, "-target", "bpf", "-Wall", targetArch, "-g", "-O2", "-c", bpfSourceFile, "-o", bpfOutputFile, includeDir, libbpfDir, filterDir)
 	if err != nil {
-		return err
+		return errors.Wrap(err, "unable to compile eBPF code")
 	}
 	dr.l.Info("DropReason metric compiled")
 	return nil

pkg/plugin/packetforward/packetforward_linux.go

@@ -7,14 +7,14 @@ package packetforward
 
 import (
 	"context"
-	"errors"
 	"fmt"
 	"path"
 	"runtime"
 	"syscall"
 	"time"
 
 	kcfg "github.com/microsoft/retina/pkg/config"
+	"github.com/pkg/errors"
 
 	hubblev1 "github.com/cilium/cilium/pkg/hubble/api/v1"
 	"github.com/cilium/ebpf"
@@ -124,7 +124,7 @@ func (p *packetForward) Compile(ctx context.Context) error {
 	// Keep target as bpf, otherwise clang compilation yields bpf object that elf reader cannot load.
 	err = loader.CompileEbpf(ctx, "-target", "bpf", "-Wall", targetArch, "-g", "-O2", "-c", bpfSourceFile, "-o", bpfOutputFile, includeDir, libbpfDir)
 	if err != nil {
-		return err
+		return errors.Wrap(err, "error compiling ebpf code")
 	}
 	p.l.Info("Packet forwarding metric compiled")
 	return nil