feat(helm): add support for priorityClassName #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
I think this is probably a good addition given Retina's use cases. @anubhabMajumdar -- should we be making these changes in the legacy charts or the hubble ones? |
|
@timraymond i don't see why we shouldn't make this change in both legacy and hubble |
iarlyy
force-pushed
the
add-priorityclassname
branch
2 times, most recently
from
e7ea974
to
d48ba10
Compare
iarlyy
force-pushed
the
add-priorityclassname
branch
from
d48ba10
to
b3c38b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for configuring
priorityClassNamefor the agent and operator pods.Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.