tool: update kapinger to make random dns queries #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Castilio dos Santos <[email protected]>
|
What is the intention of this PR? This looks like it issues DNS queries for 'random' domain names? What is the scale? 1, 10, 100, 1000, 10000? After these queries are executed what is the consumer? Are we measuring something? This sounds like the consumer doesn't have a great means of testing. |
MikeZappa87
requested changes
Nov 22, 2024
timraymond
requested changes
Nov 22, 2024
| @@ -30,7 +31,7 @@ func (k *KapingerDNSClient) MakeRequests(ctx context.Context) error { | |||
| case <-ticker.C: | |||
| go func() { | |||
| for i := 0; i < k.volume; i++ { | |||
| domain := "retina.sh" | |||
| domain := randomString(20) + ".com" | |||
There was a problem hiding this comment.
Please use .test instead of .com for tests involving DNS per RFC 2606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update kapinger to make random dns queries
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.