-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: operator v2 (for Hubble control plane) #444
Conversation
63a59e7
to
b43ed3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jacques for all the work here. I think we should revert all changes around the licenses, and I had some questions about other changes.
Also, can you add details in the PR description about your testing for legacy and new operator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes lgtm. Just ought to rebase on #432
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good. Can you verify this works with the new retina-agent changes? Update Testing Done
to show enrichment of flows works when using Hubble cli.
I added images in test section showing Hubble cli working with agent changes. |
ed5c73d
to
61495e8
Compare
Description
Writing a new operator to support Hubble in non-Cilium clusters (see #417). This operator manages all CiliumIdentities and CiliumEndpoints for the cluster.
Related Issue
Fixes #419
Checklist
git commit -S -s ...
). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Additional Notes