-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Introducing vector and text search #9345
Merged
Merged
Commits on Nov 5, 2024
-
Python: Introducing vector search for the new memory connectors (#8298)
<!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Initial version contains the generic classes and a implementation for Azure AI Search. TODO: other stores TODO: tests <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Configuration menu - View commit details
-
Copy full SHA for 20d7928 - Browse repository at this point
Copy the full SHA 20d7928View commit details -
Python: reordered the data folder (#8910)
<!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Reordered the data folder Removed NOT_EQUAL_TO filter clause Changed search functions to search, get_search_result and get_text_search_result for TextSearch and vectorizable_text_search and vectorized_search for VectorSearch to reflect updates to dotnet. Removed other query types for VectorSearch Added exceptions and handling of no result error. <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Tao Chen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6165d55 - Browse repository at this point
Copy the full SHA 6165d55View commit details -
Configuration menu - View commit details
-
Copy full SHA for d72db5a - Browse repository at this point
Copy the full SHA d72db5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec3a624 - Browse repository at this point
Copy the full SHA ec3a624View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cb0d9f - Browse repository at this point
Copy the full SHA 8cb0d9fView commit details -
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Syncing the python implementation with the dotnet work. Introduces VectorStoreTextSearch Methods on KernelPlugin etc Includes: - Adding additional distance and index definitions - Renamed to Top and Offset (instead of Count) - restructured base classes for different search types - add tests ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Configuration menu - View commit details
-
Copy full SHA for e536805 - Browse repository at this point
Copy the full SHA e536805View commit details -
Python: Search integration test fixes (#9497)
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> couple of small fixes for the integration tests ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Configuration menu - View commit details
-
Copy full SHA for da2faa0 - Browse repository at this point
Copy the full SHA da2faa0View commit details -
Python: Search - addressed feedback from reviews (#9517)
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Added new exceptions Cleaned up the samples removed old/commented code ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Configuration menu - View commit details
-
Copy full SHA for 10abd5a - Browse repository at this point
Copy the full SHA 10abd5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bceeeaa - Browse repository at this point
Copy the full SHA bceeeaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a4308e - Browse repository at this point
Copy the full SHA 6a4308eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5736f1a - Browse repository at this point
Copy the full SHA 5736f1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15c75ef - Browse repository at this point
Copy the full SHA 15c75efView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff5df13 - Browse repository at this point
Copy the full SHA ff5df13View commit details
Commits on Nov 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0c21c5c - Browse repository at this point
Copy the full SHA 0c21c5cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.