Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsiderEmptyDataSourceAsInconclusive throws to catch the exception on the next line #3006

Closed
nohwnd opened this issue May 28, 2024 · 0 comments · Fixed by #4057
Closed

ConsiderEmptyDataSourceAsInconclusive throws to catch the exception on the next line #3006

nohwnd opened this issue May 28, 2024 · 0 comments · Fixed by #4057

Comments

@nohwnd
Copy link
Member

nohwnd commented May 28, 2024

When 0 items are produced and the code does not throw, we throw just to catch the exception. This could be made more efficient by extracting the catch and using it in if and catch paths.

https://grep.app/search?q=%26%26%20.%2AConsiderEmptyDataSourceAsInconclusive&regexp=true

Code is introduced here: https://github.com/microsoft/testfx/pull/2771/files

PR has no comments that would mention this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants