Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor unnecessary try/catch #4057

Merged
merged 11 commits into from
Nov 19, 2024
Merged

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Nov 13, 2024

Fixes #3006

Evangelink
Evangelink previously approved these changes Nov 15, 2024
@Evangelink Evangelink enabled auto-merge (squash) November 15, 2024 08:19
@Youssef1313
Copy link
Member Author

@Evangelink I'm disabling auto-merge as I'm making changes since your last review. Once I'm able to get it green, I'll let you know to re-review.

Evangelink
Evangelink previously approved these changes Nov 19, 2024
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits but LGTM, thanks @Youssef1313

@Evangelink Evangelink enabled auto-merge (squash) November 19, 2024 13:47
@Evangelink Evangelink merged commit bde4e5a into main Nov 19, 2024
6 checks passed
@Evangelink Evangelink deleted the dev/ygerges/unnecessary-try-catch branch November 19, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConsiderEmptyDataSourceAsInconclusive throws to catch the exception on the next line
2 participants