Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @response.rsp files #3730

Closed
MarcoRossignoli opened this issue Aug 30, 2024 · 6 comments · Fixed by #4072
Closed

Support @response.rsp files #3730

MarcoRossignoli opened this issue Aug 30, 2024 · 6 comments · Fixed by #4072
Assignees
Labels
Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library In-PR sprint Type: Discussion Type: Feature

Comments

@MarcoRossignoli
Copy link
Contributor

MarcoRossignoli commented Aug 30, 2024

Command line can contains long arguments (i.e. --filter).
Allow to pass a response file will help these scenario.

AB#2302861

@MarcoRossignoli MarcoRossignoli added the Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library label Aug 30, 2024
@Evangelink
Copy link
Member

I think this should be handled as part of the config file (see #3562 and #3499). I am not sure there is really a need for a filter file.

@nohwnd
Copy link
Member

nohwnd commented Aug 30, 2024

FWIW I've made a custom implementation for this a long time ago in vstest. Your implementation would be easier because you have neither default arguments, or -- settings.

https://github.com/nohwnd/vstest/blob/commandline-parser/src/vstest.console/CommandLine/Parser.cs#L536

@MarcoRossignoli
Copy link
Contributor Author

I think this should be handled as part of the config file (see #3562 and #3499). I am not sure there is really a need for a filter file.

What you mean, the response file will contains all the command line not only the filter. Or have I misunderstood?

@thomhurst
Copy link
Contributor

thomhurst commented Aug 30, 2024

What you mean, the response file will contains all the command line not only the filter. Or have I misunderstood?

Is this not what I suggested in #3499 ?

@MarcoRossignoli
Copy link
Contributor Author

MarcoRossignoli commented Sep 1, 2024

Is this not what I suggested in #3499 ?

This feature is slightly different. It used when the command line for some reason is really log and cannot fit the max length of the command line. The feature discussed in the other issue doesn't fit well the "on the fly" generation, because users should parse json and rewrite a new one. Here it's simply a generation of plain command line with one option per line.

@MarcoRossignoli
Copy link
Contributor Author

This is a key feature to unblock the --filterByIds "long list of ids" that is used in some tooling to partition or select specific tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library In-PR sprint Type: Discussion Type: Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants