Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support rsp in MTP #4072

Merged
merged 10 commits into from
Nov 20, 2024
Merged

Support rsp in MTP #4072

merged 10 commits into from
Nov 20, 2024

Conversation

Youssef1313
Copy link
Member

Fixes #3730

@microsoft-github-policy-service microsoft-github-policy-service bot added Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library Type: Discussion Type: Feature labels Nov 17, 2024
@Youssef1313 Youssef1313 force-pushed the support-rsp branch 5 times, most recently from 8ee8e46 to 41d38e8 Compare November 17, 2024 16:06
@Youssef1313 Youssef1313 marked this pull request as ready for review November 18, 2024 09:26
MarcoRossignoli
MarcoRossignoli previously approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@Youssef1313
Copy link
Member Author

Thanks for the reviews @MarcoRossignoli @Evangelink. I addressed your feedback

@Evangelink Evangelink merged commit 01609e7 into microsoft:main Nov 20, 2024
6 checks passed
@Youssef1313 Youssef1313 deleted the support-rsp branch November 20, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoRossignoli MarcoRossignoli MarcoRossignoli left review comments

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library Type: Discussion Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support @response.rsp files
3 participants
@Youssef1313 @MarcoRossignoli @Evangelink