Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Microsoft.Testing.Framework and related projects to Microsoft.Testing.Internal.Framework #2579

Closed
wants to merge 6 commits into from

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Mar 15, 2024

Microsoft.Testing.Framework namespace is used by the new mstest engine. To avoid confusion rename "TATF" to Microsoft.Testing .Internal. Framework

Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect that you have to update the source gen tooling before moving this PR forward.

Comment on lines +7 to +8
using FrameworkTestNodeUid = Microsoft.Testing.Internal.Framework.TestNodeUid;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
using FrameworkTestNodeUid = Microsoft.Testing.Internal.Framework.TestNodeUid;
using FrameworkTestNodeUid = Microsoft.Testing.Internal.Framework.TestNodeUid;

@Evangelink Evangelink marked this pull request as draft March 15, 2024 21:35
@nohwnd nohwnd marked this pull request as ready for review March 20, 2024 13:14
@nohwnd
Copy link
Member Author

nohwnd commented Mar 20, 2024

Should work now, Windows tests passed, but not linux, because I screwed up the name casing in csproj, and linux file system is case sensitive.

@nohwnd
Copy link
Member Author

nohwnd commented Mar 20, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nohwnd nohwnd closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants