Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project samples for MSTest.Sdk #2675

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Evangelink
Copy link
Member

No description provided.

@MarcoRossignoli MarcoRossignoli enabled auto-merge (squash) April 8, 2024 10:15
@Evangelink Evangelink disabled auto-merge April 8, 2024 10:15
@Evangelink Evangelink merged commit c748ee1 into microsoft:main Apr 8, 2024
2 of 7 checks passed
@Evangelink Evangelink deleted the mstest-sdk-samples branch April 8, 2024 10:15
@cremor
Copy link

cremor commented May 23, 2024

@Evangelink You've added 3 projects in this PR. If you compare their "equivalent project configuration when not using MSTest.Sdk" parts, one of them says it references the MSTest meta package while the other two say that they reference individual MSTest packages. And the native AOT sample doesn't even reference MSTest.Analyzers. Is this really correct?

@Evangelink
Copy link
Member Author

MSTest package is a metapackage that only simplified referencing other packages (one part of the SDK functionality) but is equivalent to referencing directly the packages. Do you have a preference? Would you expect to see a comment saying that?

For Native AOT, we definitely can add the analyzers if that's the point of your question.

@cremor
Copy link

cremor commented May 23, 2024

I know that, I was just wondering if there was a reason for the shown code in the samples. E.g. for AOT it might really not reference the meta package if MSTest.TestAdapter doesn't work with AOT.

I prefer referencing the meta package, but I think the samples should show how the SDK actually works.

@Evangelink Evangelink mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants