Implement 'Use proper Assert methods' analyzer #4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Nov 17, 2024
Comment on lines
+65
to
+66
| DiagnosticSeverity.Info, | ||
| isEnabledByDefault: false); |
There was a problem hiding this comment.
@Evangelink I just remembered that we haven't discussed this. Is the current severity and being not enabled by default okay? Or should it be enabled by default?
There was a problem hiding this comment.
I think we can enable by default, I am only careful about the warning severity and outside of breaking change version I try to set it as warning only for rules where failure to comply would result in runtime error as we have many users with warn as error who would get broken by bumping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the analyzer part of #3315. Codefix isn't yet implemented.