Pass multiple errors #4054
Merged
Pass multiple errors #4054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,13 +80,19 @@ internal static class FailedTestResultMessageFieldsId | |||
| public const ushort State = 3; | |||
| public const ushort Duration = 4; | |||
| public const ushort Reason = 5; | |||
| public const ushort ErrorMessage = 6; | |||
| public const ushort ErrorStackTrace = 7; | |||
| public const ushort ExceptionMessageList = 6; | |||
| public const ushort StandardOutput = 8; | |||
There was a problem hiding this comment.
We are missing the 7 value here.
| case FailedTestResultMessageFieldsId.ErrorMessage: | ||
| errorMessage = ReadStringValue(stream, fieldSize); | ||
| break; | ||
| case FailedTestResultMessageFieldsId.ExceptionMessageList: |
There was a problem hiding this comment.
Please extract this as a separate method.
|
Merging this as agreed with Mariam so she has easier time using my changes, will address the refactorings in separate PR/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing multiple errors to dotnet test, fix code to handle multiple errors without relying on Exception type that we won't serialize.
Fix discovery in dotnet test, and report exit codes and outputs when exe fails so we have more info in dotnet test.