[PROTOTYPE] Implement TestCultureAttribute #4055
Draft
+77
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Nov 12, 2024
| _previousUICulture = CultureInfo.CurrentUICulture; | ||
|
|
||
| var newCulture = new CultureInfo(cultureName); | ||
| // TODO: Should we set both? Should we have different attribute? Same attribute with two arguments? |
There was a problem hiding this comment.
This needs to be discussed first.
Youssef1313
commented
Nov 12, 2024
Comment on lines
+72
to
+74
| // TestMethodInfo isn't accessible here :/ | ||
| // Can we add TestCultureName to the *public* interface? | ||
| // Or should we introduce an internal interface ITestMethod2 : ITestMethod :/ |
Youssef1313
commented
Nov 22, 2024
|
|
||
| var newCulture = new CultureInfo(cultureName); | ||
| // TODO: Should we set both? Should we have different attribute? Same attribute with two arguments? | ||
| CultureInfo.CurrentCulture = newCulture; |
There was a problem hiding this comment.
Important consideration: Validate if that approach is going to work well for tests running in parallel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #579