Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ValueTask-returning test methods for all target frameworks #4059

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

Youssef1313
Copy link
Member

Fixes #4056

Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits but otherwise LGTM. Let's see if there are some unanticipated problems with our net framework users.

eng/Versions.props Outdated Show resolved Hide resolved
src/Adapter/MSTest.TestAdapter/MSTest.TestAdapter.nuspec Outdated Show resolved Hide resolved
@Evangelink Evangelink merged commit bb5de81 into microsoft:main Nov 20, 2024
6 checks passed
@Youssef1313 Youssef1313 deleted the valuetask-netframework branch November 20, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow tests that return a ValueTask to be discovered
2 participants