Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reflection provider for class constructors #4079

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Nov 19, 2024

Fixes oversight in code where we grab the constructors from Reflection rather than getting them from the metadata provider.

Replace #4033

Evangelink
Evangelink previously approved these changes Nov 19, 2024
@Evangelink Evangelink enabled auto-merge (squash) November 19, 2024 13:57
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are now breaking on MSTestAdapter.UnitTest

@nohwnd nohwnd disabled auto-merge November 20, 2024 15:41
@nohwnd nohwnd merged commit 4c774e9 into main Nov 20, 2024
5 checks passed
@nohwnd nohwnd deleted the ctors-via-provider branch November 20, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants