Produce binlog for test step #5192
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft until we see first how #5111 will go. |
Youssef1313
commented
Mar 9, 2025
Youssef1313
commented
Mar 9, 2025
Youssef1313
force-pushed
the
produce-binlog-test
branch
from
7115ee3 to
efb33f5
Compare
Evangelink
reviewed
Mar 23, 2025
Comment on lines
+141
to
+143
| # Both the Build and Test steps produces binlog named Build.binlog (https://github.com/dotnet/arcade/issues/15611) | ||
| # We want to publish both binlogs. | ||
| # So, as a hack, we build, rename, test, rename again. |
There was a problem hiding this comment.
@ViktorHofer I think you did mention a "better" way than the rename but I cannot recall what.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.