Implement lowerings for argmin and argmax #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triton
argmin
andargmax
both lower tott.reduce
ops that have identicalsemantics identical to linalg.reduce op, so we can clone
tt.reduce
body tolinalg.reduce
directly. Unfortunately, we still need to perform pattern matchingto know what reduce ops we are dealing with so that we know how to initialize
the initial reduce values correctly.
We can do this in a generic way without pattern matching by always using
the first elements along the reduction axis and perform the reduction on
the remaining elements. However, this results in creatings sub-tensors that
aren't always multiple of 2s, which are sub-optimal for certain hardware.