Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use partial conversion in TritonToLinalg #59

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

nhat-nguyen
Copy link
Collaborator

@nhat-nguyen nhat-nguyen commented Nov 16, 2023

Use partial conversion instead of full conversion in TritonToLinalg. With partial conversion, the pass can still succeed without having to fully cover the whole Triton dialect.

This gives more flexibility for users to use IR that we don't have coverage for yet. It also opens up the possibility of converting unstructured pointer accesses to block pointers instead of directly to linalg because with the full conversion, all triton ops have to be converted to something different.

I have also fixed incorrect usages of op.emitOpError and change them to rewriter.notifyMatchFailure.

Fixes #18.

@nhat-nguyen nhat-nguyen changed the title Update Use partial conversion in TritonToLinalg Nov 16, 2023
@nhat-nguyen nhat-nguyen merged commit c2fb18d into main Nov 16, 2023
3 checks passed
@nhat-nguyen nhat-nguyen deleted the nhat/partial_conversions branch November 16, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: failed to legalize operation 'tt.extern_elementwise'
2 participants