Use partial conversion in TritonToLinalg #59
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use partial conversion instead of full conversion in TritonToLinalg. With partial conversion, the pass can still succeed without having to fully cover the whole Triton dialect.
This gives more flexibility for users to use IR that we don't have coverage for yet. It also opens up the possibility of converting unstructured pointer accesses to block pointers instead of directly to linalg because with the full conversion, all triton ops have to be converted to something different.
I have also fixed incorrect usages of
op.emitOpError
and change them torewriter.notifyMatchFailure
.Fixes #18.