Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ARM 1ES pool #71

Closed
wants to merge 2 commits into from
Closed

Conversation

NathanielMcVicar
Copy link

This tests the ARM 1ES pool, once the pool is working #66 can move forward and the workflow temporarily created here can be deleted.

@danikhan632
Copy link
Contributor

danikhan632 commented Dec 1, 2023

This tests the ARM 1ES pool, once the pool is working #66 can move forward and the workflow temporarily created here can be deleted.

Should be able to close my PR and move it to here now that workflow runner is setup, the only concern I have is from #72 since triton made some update that breaks this repo and that predates my PR that added the support to the setup.py to enable arm64. If we have to use a build of triton that predates triton-lang/triton@801bb5f then we will still have to transplant a newer setup.py as shown in my PR in order to run the workflow. Also the triton repo has not re-run the llvm build workflow so arm llvm doesn't exist yet. But hopefully this will be dealt with and #66 can be closed out

@NathanielMcVicar
Copy link
Author

NathanielMcVicar commented Dec 1, 2023

@danikhan632

Should be able to close my PR and move it to here

My intent was that you would close this PR once you confirmed yours was working with the Pool, since this was just a test workflow and has nothing to do with the ARM pool itself, but I'll leave that up to you. Thanks again for adding support!

@danikhan632
Copy link
Contributor

@danikhan632

Should be able to close my PR and move it to here

My intent was that you would close this PR once you confirmed yours was working with the Pool, since this was just a test workflow and has nothing to do with the ARM pool itself, but I'll leave that up to you. Thanks again for adding support!

Thanks for the clarification, looks like I'm going to have to keep testing the workflow with the arm pool since it failed😭, still trying to figure out why that one test for the x64 failed but it doesn't look like the arm pool has pip installed for python3, could that be changed by running

sudo apt-get -y install python3-pip      

or should I install pip as part of the workflow?

@NathanielMcVicar
Copy link
Author

Unfortunately, I can't find a complete list of installed software for the ARM image. For the GitHub hosted runners you can find it here: https://github.com/actions/runner-images#software-and-image-support. It's not ideal, but I think you will just have to continue with your current trial and error process to get the software you need installed.

@danikhan632
Copy link
Contributor

Unfortunately, I can't find a complete list of installed software for the ARM image. For the GitHub hosted runners you can find it here: https://github.com/actions/runner-images#software-and-image-support. It's not ideal, but I think you will just have to continue with your current trial and error process to get the software you need installed.

sounds good, wanted to know if its possible if I could manually trgger workflows. Not being able to manually do so does make trial and error a bit harder

@NathanielMcVicar
Copy link
Author

sounds good, wanted to know if its possible if I could manually trgger workflows. Not being able to manually do so does make trial and error a bit harder

Oh, I see what you mean. You need to add an on: workflow_dispatch: trigger to integration-tests.yml. You can look at nightly-tests.yml for an example. Then you should be able to trigger it manually against your branch.

@danikhan632
Copy link
Contributor

sounds good, wanted to know if its possible if I could manually trgger workflows. Not being able to manually do so does make trial and error a bit harder

Oh, I see what you mean. You need to add an on: workflow_dispatch: trigger to integration-tests.yml. You can look at nightly-tests.yml for an example. Then you should be able to trigger it manually against your branch.

thank you, also just wanted to ask but the arm test runs on Github Hosted Runner? I thought it was self-hosted so the standard action runner software wouldn't really apply, I think.

@nhat-nguyen
Copy link
Collaborator

Closing since #103 has now been merged.

@nhat-nguyen nhat-nguyen closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants