Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the introduction of emitters for sdk clients. #5663
base: main
Are you sure you want to change the base?
Add the introduction of emitters for sdk clients. #5663
Changes from 1 commit
9f7f5f4
bb53d7d
ff9fc0d
c7622ce
b780da9
b55dcce
ff3a26e
9ba0e86
f2c4dfe
469c96a
d77ab16
47db420
625ddb4
15d942a
199426f
1f7a7a2
da71388
56992b1
021de38
0664619
cd1db4d
a431a92
bda5d43
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use starlight steps to hav ea nicely presented stepped tutorial https://starlight.astro.build/components/steps/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The required format in
Steps
would conflict with prettier check result which requires no space before code block.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it works fine but you have to double indent the content(then format, not sure what is the exact rule but it works), this this pr for example https://github.com/microsoft/typespec/pull/5907/files#diff-a8e95e435a79ecab53d5b97dcf924fa2e247d0d7ba63a2e27e8062731d3b1e30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we link to the official documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be good that we include it right there on the website as well(in the same way we have docs for the other emitters)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to use the readme page of each emitter,e.g.
https://www.npmjs.com/package/@typespec/http-client-csharp
However, those pages seem to be out of date which requires SDK codeGen owner to improve.