Use reportDiagnostics rather than throwing for known errors #5854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
packages/http-client-csharp/emitter/src/lib/client-model-builder.ts
Outdated
Show resolved
Hide resolved
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
jorgerangel-msft
approved these changes
Feb 4, 2025
JoshLove-msft
force-pushed
the
use-report-diags
branch
from
050d13e to
ea20ea9
Compare
JoshLove-msft
force-pushed
the
use-report-diags
branch
from
782c7e0 to
3ee3f31
Compare
m-nash
approved these changes
Feb 10, 2025
dmnorc
pushed a commit
to dmnorc/typespec
that referenced
this pull request
Feb 18, 2025
…t#5854) Fixes microsoft#5743 Also removes use of singleton Logger as using global state is not a best practice for emitters. --------- Co-authored-by: Timothee Guerin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5743
Also removes use of singleton Logger as using global state is not a best practice for emitters.