utcDateTime defaults to Protobuf.WellKnown.Timestamp
#7089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjb1982
requested review from
bterlson,
markcowl,
allenjzhang,
timotheeguerin,
witemple-msft,
chrisradek and
AlitzelMendez
as code owners
microsoft-github-policy-service
bot
added
the
emitter:protobuf
|
@microsoft-github-policy-service agree company="nclk" |
tjb1982
changed the title
utcDateTime defaults to Protobuf.WellKnown.TimestamputcDateTime defaults to Protobuf.WellKnown.Timestamp
tjb1982
changed the title
utcDateTime defaults to Protobuf.WellKnown.TimestamputcDateTime defaults to Protobuf.WellKnown.Timestamp
tjb1982
changed the title
utcDateTime defaults to Protobuf.WellKnown.TimestamputcDateTime defaults to Protobuf.WellKnown.Timestamp
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
TypeSpec.utcDateTimedefault toProtobuf.WellKnown.Timestampby mappingutcDateTimetoref("google.prototype.Timestamp")making sure to import "google/protobuf/timestamp.proto".This required the creation of a new type
ProtoTypeInfowrapping aProtoTypewithsourceinfo to communicate toaddTypethat this particular scalar is actually a reference that needs to be imported.As reported in #1882