[emitter-framework] Use internal refkeys for declarations #7205
+106
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can try these changes here
|
maorleger
requested review from
joheredi,
timotheeguerin,
timovv,
qiaozha,
MaryGao,
xirzec,
bterlson,
markcowl,
allenjzhang,
witemple-msft,
chrisradek and
AlitzelMendez
as code owners
maorleger
commented
May 2, 2025
| @@ -17,15 +17,8 @@ export function Models(props: ModelsProps) { | |||
| <ts.SourceFile path={props.path ?? "models.ts"}> | |||
| <For each={dataTypes} joiner={"\n"} hardline> | |||
| {(type) => { | |||
| if ($.model.is(type) && $.model.isHttpFile(type)) { | |||
There was a problem hiding this comment.
Was chatting with @joheredi and this was no longer needed, File is handled just fine as a builtin
bterlson
reviewed
May 2, 2025
bterlson
reviewed
May 2, 2025
packages/emitter-framework/src/typescript/components/class-method.tsx
Outdated
Show resolved
Hide resolved
bterlson
reviewed
May 2, 2025
packages/emitter-framework/src/typescript/components/enum-declaration.tsx
Outdated
Show resolved
Hide resolved
bterlson
reviewed
May 2, 2025
packages/emitter-framework/src/typescript/components/static-serializers.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently the emitter framework defaults refkeys to simply refkey(type), which is quite presumptuous - other declarations may want such a refkey. The emitter framework should use its own internal refkeys to track declarations it knows about.
This PR updates the internal refkey generation for declarations to use the internal refkeys while plumbing the emitter provided refkeys through. In addition, any non-declarations will use internal unique refkeys.
Partially addresses #6919