Heap refactor #51
Merged
Heap refactor #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the alloc parameter from a few function * Shared::release * Object::dealloc This is a gradual move over a series of commits to get the runtime to have a better defined interface to the allocator.
mjp41
force-pushed
the
heap_refactor
branch
from
30e90ed
to
db95caf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original design of the runtime passed around the allocator parameter, but this was not done consistently, resulting in
ThreadAlloc::get()being inserted to get the current allocator. This create a strong dependence on snmalloc in bizarre places.This PR
verona::rt::heapnamespace for accessing the allocation routinesrt::heapnamespace.Add a replay allocator for better detecting ABA problems.The third entry is highlighted in #50, where we have observed that the ASAN slowing down returning memory results in it being very challenging to detect ABA problems with systematic testing. This alternative allocator improves that situation.Update to add Replay allocator in subsequent PR.